Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

print sccache stats in builds #1712

Merged
merged 1 commit into from
Oct 29, 2024
Merged

print sccache stats in builds #1712

merged 1 commit into from
Oct 29, 2024

Conversation

jameslamb
Copy link
Member

Description

Contributes to rapidsai/build-planning#111

Proposes some small packaging/CI changes, matching similar changes being made across RAPIDS.

  • printing sccache stats to CI logs
  • updating to the latest rapids-dependency-file-generator (v1.16.0)
  • reducing verbosity of pip wheel in wheel builds

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@jameslamb jameslamb added non-breaking Non-breaking change 5 - DO NOT MERGE Hold off on merging; see PR for details improvement Improvement / enhancement to an existing function labels Oct 29, 2024
@jameslamb jameslamb mentioned this pull request Oct 29, 2024
Closed
@github-actions github-actions bot added the ci label Oct 29, 2024
@jrhemstad
Copy link
Contributor

jrhemstad commented Oct 29, 2024 •
edited
Loading

We have a script in CCCL that will compute a more convenient hit rate number that you are welcome to steal: https://github.com/NVIDIA/cccl/blob/main/ci/sccache_stats.sh

Example in our CI log: https://github.com/NVIDIA/cccl/actions/runs/11574973643/job/32222977763?pr=2646#step:5:1434

@jameslamb
Copy link
Member Author

Thanks very much @jrhemstad ! For the moment, we're looking to add the stats in their rawest form to logs, to be scraped by some automation that folks in RAPIDS are working on to help with profiling CI.

@jameslamb jameslamb removed the 5 - DO NOT MERGE Hold off on merging; see PR for details label Oct 29, 2024
@jameslamb jameslamb changed the title WIP: [DO NOT MERGE] print sccache stats in builds print sccache stats in builds Oct 29, 2024
@jameslamb jameslamb marked this pull request as ready for review October 29, 2024 16:06
@jameslamb jameslamb requested a review from a team as a code owner October 29, 2024 16:06
@jameslamb
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 47dae24 into rapidsai:branch-24.12 Oct 29, 2024
58 checks passed
@jameslamb jameslamb deleted the print-sccache-stats branch October 29, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AyodeAwe AyodeAwe AyodeAwe approved these changes

Assignees
No one assigned
Labels
ci improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
RMM Project Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jameslamb @jrhemstad @AyodeAwe